[Feature] Add the option to autoplay animated images#6166
Merged
bmarty merged 5 commits intoelement-hq:developfrom May 30, 2022
Merged
[Feature] Add the option to autoplay animated images#6166bmarty merged 5 commits intoelement-hq:developfrom
bmarty merged 5 commits intoelement-hq:developfrom
Conversation
networkException
added a commit
to networkException/element-android
that referenced
this pull request
May 26, 2022
Signed-off-by: networkException <git@nwex.de>
networkException
force-pushed
the
autoplay-animated-images
branch
from
272cec1 to
de40100
Compare
bmarty
approved these changes
May 30, 2022
Member
bmarty
left a comment
bmarty
left a comment
There was a problem hiding this comment.
Thanks for the PR.
LGTM, just a small typo to fix.
Did not run the code though.
networkException
added a commit
to networkException/element-android
that referenced
this pull request
May 30, 2022
Signed-off-by: networkException <git@nwex.de>
networkException
force-pushed
the
autoplay-animated-images
branch
from
de40100 to
792907d
Compare
This patch adds a new switch to VectorPreferences, the vector settings preferences view and various classes propergating the set value of the switch into parts of the application touched by the following patches. Signed-off-by: networkException <git@nwex.de>
This patch adds the messageType field to MessageInformationData, containing a nullable string representation of the message event's type. Signed-off-by: networkException <git@nwex.de>
This patch removes dontAnimate() in the createGlideRequest() builder conditionally depending on the user's animated image autoplay preferences. Resolves element-hq#1160, element-hq#5094 Signed-off-by: networkException <git@nwex.de>
This patch updates the logic checking whether to show the playContentView to not show it when an animated image message would autoplay its animation. Signed-off-by: networkException <git@nwex.de>
Signed-off-by: networkException <git@nwex.de>
networkException
force-pushed
the
autoplay-animated-images
branch
from
792907d to
fedc637
Compare
bmarty
reviewed
May 30, 2022
| <string name="settings_chat_effects_title">Show chat effects</string> | ||
| <string name="settings_chat_effects_description">Use /confetti command or send a message containing ❄️ or 🎉</string> | ||
| <string name="settings_autoplay_animated_images_title">Autoplay animated images</string> | ||
| <string name="settings_autoplay_animated_images_summary">Play animated images in the timeline as soon as they are visible</string> |
Member
There was a problem hiding this comment.
I am happy with this wording. Wording on Web is Autoplay GIFs:
We may iterate later
15 tasks
piersonleo
pushed a commit
to piersonleo/element-android
that referenced
this pull request
Jun 7, 2022
Signed-off-by: networkException <git@nwex.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Content
This pull request adds a new switch to the preferences, allowing users to enable autoplaying of animated images in their room timeline.
Motivation and context
This feature is already present in element-web and was commonly requested by the community:
The pull request resolves #1160, resolves #5094
Screenshots / GIFs
Tests
Tested devices
Checklist